Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# Files are not recognized properly #326

Closed
less0 opened this issue Aug 1, 2022 · 3 comments
Closed

C# Files are not recognized properly #326

less0 opened this issue Aug 1, 2022 · 3 comments
Assignees
@redcatbear
Labels
feature

Comments

@less0
Copy link

less0 commented Aug 1, 2022

Description

OFT expects C# to have the file extension .c#, but the default extension in the .NET World is .cs, therefor C# that is in a .cs file is ignored by OFT.

Steps to Reproduce

  1. Extract the files from Demo.zip
  2. Run OFT on the folder the files were extracted to

Expected behavior

The spec object req~demo~1 should be covered, because it's tagged in the Test.cs file, but is not. If the file is renamed to Test.c# it's covered correctly.

Environment

  • OFT: 3.5.0
  • OS: macOS 10.14.6
  • Java Version: 18.0.2+9-61
@redcatbear redcatbear self-assigned this Aug 2, 2022
redcatbear added a commit that referenced this issue Aug 2, 2022
@redcatbear
#326: Added support for .cs extension in TagImporterFactory. Upda…
e8f3ee5 
…ted user guide.
@redcatbear redcatbear mentioned this issue Aug 2, 2022
Merged
@redcatbear
Copy link
Collaborator

redcatbear commented Aug 2, 2022 •
edited
Loading

Added support for .cs extension in TagImporterFactory. @kaklakariada, please review #327.

redcatbear added a commit that referenced this issue Aug 7, 2022
@redcatbear @kaklakariada
#326: Import files with .cs extension (#327)
ebe16f5 
* #326: Added support for `.cs` extension in `TagImporterFactory`. Updated user guide.

Co-authored-by: Christoph Pirkl <github@chp1.net>
@redcatbear
Copy link
Collaborator

@less0, I fixed the '.cs' issue. The change is now on the develop branch and will be part of the next release. Sorry that it took so long, but at the moment I only have time on the weekend.

@kaklakariada
Copy link
Contributor

@less0, this is fixed in release 3.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redcatbear redcatbear

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@redcatbear @kaklakariada @less0