Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonar warnings #329

Merged
merged 9 commits into from
Aug 14, 2022
Merged

Fix sonar warnings #329

merged 9 commits into from
Aug 14, 2022

Conversation

kaklakariada
Copy link
Contributor

This fixes sonar warnings, mostly about calling multiple methods in assertThrows().

Copy link
Collaborator

@redcatbear redcatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor improvement requested.

Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kaklakariada kaklakariada merged commit a3cba92 into develop Aug 14, 2022
@kaklakariada kaklakariada deleted the fix-sonar-warnings branch August 14, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants