Skip to content
This repository has been archived by the owner on Apr 8, 2022. It is now read-only.

Added Dynamic switching for color format #111

Merged
merged 2 commits into from
Apr 8, 2015
Merged

Added Dynamic switching for color format #111

merged 2 commits into from
Apr 8, 2015

Conversation

duckzland
Copy link
Contributor

User can enter different color format and the picker will change the format type dynamically

Adding true dynamic format switching capabilities, when user set the options format to false the dynamic switching occurs.
It will change the color format as user input the color code in the textfield or use the picker to select the color.
I
@itsjavi
Copy link
Owner

itsjavi commented Apr 8, 2015

nice addition! it may then fix #86
But I think that we should provide automatic format changing in every case, even if the user specified the format option.
I would then suggest to destroy and create again the colorpicker instance, setting the new format in the options, replacing the old one. Then we will see the alpha bar only when needed.
This would simplify all the logic required.

itsjavi pushed a commit that referenced this pull request Apr 8, 2015
Added Dynamic switching for color format
@itsjavi itsjavi merged commit f1c87e3 into itsjavi:master Apr 8, 2015
@duckzland
Copy link
Contributor Author

I think it would be great if we show the alpha by default no matter what is the format set, but the value will dynamically changes from rgba or hsla to hex or rgb depending if user set the format to rgb or hex when the alpha set to 0?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants