Skip to content
This repository has been archived by the owner on Apr 8, 2022. It is now read-only.

Trigger change event on textbox when color picked #192

Merged
merged 1 commit into from
Feb 2, 2017

Conversation

Jaza
Copy link
Contributor

@Jaza Jaza commented Jan 3, 2017

No description provided.

@itsjavi
Copy link
Owner

itsjavi commented Jan 3, 2017

Thanks. This will fix #145

@@ -227,6 +227,7 @@ Colorpicker.prototype = {
val = val || this.color.toString(this.format, false);
if (this.input !== false) {
this.input.prop('value', val);
this.input.trigger('change');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One observation: if the new color is the same as the previous one, should we really trigger this event?

Copy link
Owner

@itsjavi itsjavi Jan 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as requested in other of your PR, the regeneration of the dist files is required so I can merge this directly.

@itsjavi itsjavi merged commit a05ff4e into itsjavi:master Feb 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants