Skip to content
This repository has been archived by the owner on Apr 8, 2022. It is now read-only.

Option to disable automatic conversion between HEX3and HEX6 colors #325

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

erehulka
Copy link
Contributor

Description

Added option to not automatically convert HEX3 colors (#RGB) to HEX6 (#RRGGBB). Corresponding option example has been added to Basics.hbs.

This has been addressed as an issue for quite some time, and unfortunately it wasn't possible to fix it without changing the source code, which wasn't the best idea, if this was installed via npm, or composer.

Everything has been checked and is working fine. If something will come up, I can change and fix this code.

Check list

Please fill this check list before submitting a pull request:

  • The build process has been run (npm run build) and does not contain any errors.
  • All tests are green after running npm run test.
  • New tests have been added or modified for the introduced changes.
  • New examples have been added for the newly introduced features.
  • All the examples are still working as expected compared to the official website.
  • This PR follows all other CONTRIBUTING.md guidelines for Pull Requests.

…(#RRGGBB). Corresponding option example has been added to Basics.hbs.
@erehulka
Copy link
Contributor Author

Btw I know it is not the most elegant solution, but it doesn’t make big changes to original code, just adds one variable that is passed in ColorItem.js.

@itsjavi itsjavi merged commit 3cfe6e7 into itsjavi:master Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants