Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix iframe height styles #56

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix(ui): fix iframe height styles #56

merged 1 commit into from
Sep 8, 2023

Conversation

jrson83
Copy link
Collaborator

@jrson83 jrson83 commented Sep 8, 2023

  • add scrollbar example to docs & react
  • fix component bottom getting trimmed
  • fix app height getting trimmed when viewing story in new tab
  • remove 100vh beeing applied to iframe, fixes app viewport much too large on mobile devices

closes #54

- fix component bottom getting trimmed
- fix app height getting trimmed when viewing story in new tab

closes #54
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8e4e278) 2.80% compared to head (b703bb8) 2.80%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #56   +/-   ##
=====================================
  Coverage   2.80%   2.80%           
=====================================
  Files         44      44           
  Lines       2746    2746           
  Branches      57      57           
=====================================
  Hits          77      77           
  Misses      2626    2626           
  Partials      43      43           

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@itsjavi itsjavi merged commit a3617b1 into itsjavi:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[bug] the iframe bottom gets trimmed when is larger than 100vh
2 participants