Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add simple display reminder to event #6

Merged
merged 2 commits into from
Jul 17, 2024
Merged

feat: add simple display reminder to event #6

merged 2 commits into from
Jul 17, 2024

Conversation

ronyu21
Copy link
Contributor

@ronyu21 ronyu21 commented Jul 15, 2024

What was changed?

Add a new api reminder() for triggering display notification before the calendar event happens. The api reminder() supports using ISO8601 Period format or DateInterval object.

kylemilloy
kylemilloy approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@kylemilloy kylemilloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool if we could have multiple reminders but this is a great start. Thanks for the addition

@kylemilloy kylemilloy merged commit 85afb3c into itsnubix:main Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylemilloy kylemilloy kylemilloy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronyu21 @kylemilloy