-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autopause logs #539
Autopause logs #539
Conversation
@eihns and @MoustacheMonkey, can you please build this container and see, if the logging issue is resolved. As I mentioned in #531 I don't know enough to reproduce this issue on my system |
I built and pushed an image of this PR's changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good especially since I wasn't totally understanding the "terminal-mc" bits. Let's see how testing goes for others.
Working perfectly, i dont know if it has something to do because im using unraid. Btw, any news for porting it to unraid template? :D [Autopause loop] MC Server listening for connections - stopping in 600 seconds |
Mmh, it's missing the resume action log from knockd, directly after pausing there should be a similar entry about resuming |
Only "problem" i see now is the running ticks behind thing. How does he know that? Is it time? Could it be paused without these "normal" "error" (so that normal crash detection doenst get broken?) |
@eihns yeah, it's always going to report that since with every tick it probably tracks the current time with this and then when un-pausing it can tell a bunch of time has passed since it last recorded a game tick. |
This update is now pushed to the main image |
Yes, i know, maybe manipulate time? Would that be possible? Like freeze time also? i guess time isnt very important inside the docker!? |
Logging is working, thanks for the fix!
|
The redirection is not necessary and might be the cause to reported problems. Also wrapping the logging to corresponding functions