Add SkipReadinessCheck flag #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
approved these changes
Sep 8, 2024
|
Were you planning on also enhancing the call here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain servers have reasons to set the max player count in SLP responses to zero, or omit the players section. The current sanity checking functionality will throw a "server not ready" error when pinging these servers. Additionally, modern servers (e.g those based on Paper) will wait with replying to SLPs until they are fully initialised, which would make the sanity check redundant.
Hence why I propose adding a
--skip-readiness-checkflag, which bypasses this check and allows servers based on https://github.com/itzg/docker-minecraft-server to pass healthchecks when they're configured to respond to SLPs this way.