Prevent crash due to large memory allocation (#291)

itzg · May 6, 2024 · f34b6e8 · f34b6e8
1 parent 09ed21d
commit f34b6e8
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/mcproto/read.go b/mcproto/read.go
@@ -160,6 +160,12 @@ func ReadFrame(reader io.Reader, addr net.Addr) (*Frame, error) {
 	if err != nil {
 		return nil, err
 	}
+
+	// Limit frame length to 2^21 - 1
+	if frame.Length > 2097151 {
+		return nil, errors.Errorf("frame length %d too large", frame.Length)
+	}
+
 	logrus.
 		WithField("client", addr).
 		WithField("length", frame.Length).