First version of Auto Scaler #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2021
vorburger
added a commit
to OASIS-learn-study/kubernetes.oasis.learn.study
that referenced
this pull request
Nov 20, 2021
vorburger
commented
Nov 20, 2021
vorburger
commented
Nov 20, 2021
vorburger
force-pushed
the
issue-11_autoscale-A
branch
from
109a0a3
to
76784a2
Compare
…string (e.g. auto scale wake up functions)
It works, but the "user experience" could subsequently still be be improved; because ideally, it should 'hang', and wait until the backend actually accepts connnections.
vorburger
force-pushed
the
issue-11_autoscale-A
branch
from
76784a2
to
42f0fdb
Compare
itzg
reviewed
Dec 21, 2021
There was a problem hiding this comment.
Still waiting on two changes important to me:
- First version of Auto Scaler #29 (comment)
- command line option to enable the auto-scaling feature where default is off
…end() as requested in code review
Understood, that's why it was marked as Draft... 🤣 Both are now done, and I'm now un-drafting this PR to signal that it's now ready for review & merge if OK for you, from my side. |
|
👍 |
itzg
reviewed
Jan 1, 2022
Co-authored-by: Geoff Bourne <itzgeoff@gmail.com>
Co-authored-by: Geoff Bourne <itzgeoff@gmail.com>
Done! (Do have a look at if I understood and fixed it correctly.) |
itzg
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21