Cache "is_math" state #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you checked this works for all buffers (i.e. newly created)? I get the impression that on_attach will be called only once, for a single buffer. |
|
Oh it seems that you are correct. Sometimes on_attach is not called. |
mscott99
force-pushed
the
performance_branch
branch
from
5fe8051 to
89d64eb
Compare
|
Do you have any profiling/benchmark? |
|
I don't, but I could run a quick check with some print statements or a counter to check the number of calls. I wont be able to do that right away though, probably in a week or so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the code was checking whether is_math for each snippet for which this was a condition. This pr changes that behaviour so that is_math is a local variable that updates anytime the buffer is modified, and then the is_math condition on the snippets will read off this local variable.