test(#30): add unit/screenshot/instrumentation tests (SQUASH)
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to fix warnings by CloseGuard need to close all the databases involved in tests after completion. --- System.logW: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks. java.lang.Throwable: Explicit termination method 'close' not called at dalvik.system.CloseGuard.$$robo$$dalvik_system_CloseGuard$openWithCallSite(CloseGuard.java:288) at dalvik.system.CloseGuard.openWithCallSite(CloseGuard.java) at dalvik.system.CloseGuard.$$robo$$dalvik_system_CloseGuard$open(CloseGuard.java:257) at jdk.internal.reflect.GeneratedMethodAccessor17.invoke(Unknown Source) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:569) at org.robolectric.shadows.ShadowCloseGuard$CloseGuardReflector$$Reflector37.open(Unknown Source) at org.robolectric.shadows.ShadowCloseGuard.open(ShadowCloseGuard.java:38) at dalvik.system.CloseGuard.open(CloseGuard.java) at android.database.sqlite.SQLiteDatabase.$$robo$$android_database_sqlite_SQLiteDatabase$openInner(SQLiteDatabase.java:1088) at android.database.sqlite.SQLiteDatabase.openInner(SQLiteDatabase.java) at android.database.sqlite.SQLiteDatabase.$$robo$$android_database_sqlite_SQLiteDatabase$open(SQLiteDatabase.java:1067) at android.database.sqlite.SQLiteDatabase.open(SQLiteDatabase.java) at android.database.sqlite.SQLiteDatabase.$$robo$$android_database_sqlite_SQLiteDatabase$openDatabase(SQLiteDatabase.java:931) at android.database.sqlite.SQLiteDatabase.openDatabase(SQLiteDatabase.java) at android.database.sqlite.SQLiteDatabase.$$robo$$android_database_sqlite_SQLiteDatabase$createInMemory(SQLiteDatabase.java:1127) at android.database.sqlite.SQLiteDatabase.createInMemory(SQLiteDatabase.java) at android.database.sqlite.SQLiteOpenHelper.$$robo$$android_database_sqlite_SQLiteOpenHelper$getDatabaseLocked(SQLiteOpenHelper.java:368) at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java) at android.database.sqlite.SQLiteOpenHelper.$$robo$$android_database_sqlite_SQLiteOpenHelper$getWritableDatabase(SQLiteOpenHelper.java:316) at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.getWritableOrReadableDatabase(FrameworkSQLiteOpenHelper.android.kt:223) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.innerGetDatabase(FrameworkSQLiteOpenHelper.android.kt:170) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.getSupportDatabase(FrameworkSQLiteOpenHelper.android.kt:144) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper.getWritableDatabase(FrameworkSQLiteOpenHelper.android.kt:97) at androidx.room.RoomDatabase.inTransaction(RoomDatabase.android.kt:826) at androidx.room.RoomDatabase.assertNotSuspendingTransaction(RoomDatabase.android.kt:606) at com.github.iusmac.sevensim.telephony.SubscriptionsDao_Impl.findBySubscriptionId(SubscriptionsDao_Impl.java:113) at com.github.iusmac.sevensim.telephony.Subscriptions.createSubscription(Subscriptions.java:202) at com.github.iusmac.sevensim.telephony.SubscriptionsImplLegacy.createSubscription(SubscriptionsImplLegacy.java:145) at com.github.iusmac.sevensim.telephony.SubscriptionsImplLegacy$1.hasNext(SubscriptionsImplLegacy.java:105) at com.github.iusmac.sevensim.telephony.Subscriptions.getSubscription(Subscriptions.java:167) at com.github.iusmac.sevensim.telephony.SubscriptionsImplLegacy.getSubscriptionForSimSlotIndex(SubscriptionsImplLegacy.java:137) at com.github.iusmac.sevensim.telephony.SubscriptionsImplLegacyTest.lambda$test_getSubscriptionForSimSlotIndex_FoundMatchesForSlotIndex$4(SubscriptionsImplLegacyTest.java:177) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:840)
Most of these classes are imported from AOSP "as-is", so testing them is out-of-scope. Others are is simply very tightly coupled with the app itself, removing the need for extra testing.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.