Skip to content

Commit

Permalink
User: Remove broken Google login (various comments)
Browse files Browse the repository at this point in the history
  • Loading branch information
SamantazFox committed Jun 11, 2023
1 parent 69f23d9 commit b06c87f
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 12 deletions.
3 changes: 1 addition & 2 deletions config/config.example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,7 @@ https_only: false
#registration_enabled: true

##
## Allow/Forbid users to log-in. This setting affects the ability
## to connect with BOTH Google and Invidious (local) accounts.
## Allow/Forbid users to log-in.
##
## Accepted values: true, false
## Default: true
Expand Down
4 changes: 0 additions & 4 deletions src/invidious/routes/api/v1/authenticated.cr
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,6 @@ module Invidious::Routes::API::V1::Authenticated
Invidious::Database::Users.subscribe_channel(user, ucid)
end

# For Google accounts, access tokens don't have enough information to
# make a request on the user's behalf, which is why we don't sync with
# YouTube.

env.response.status_code = 204
end

Expand Down
4 changes: 0 additions & 4 deletions src/invidious/routes/playlists.cr
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,6 @@ module Invidious::Routes::Playlists
end
end

if !user.password
# TODO: Playlist stub, sync with YouTube for Google accounts
# playlist_ajax(playlist_id, action, env.request.headers)
end
email = user.email

case action
Expand Down
3 changes: 1 addition & 2 deletions src/invidious/views/privacy.ecr
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,11 @@
<li>a list of channel UCIDs the user is subscribed to</li>
<li>a user ID (for persistent storage of subscriptions and preferences)</li>
<li>a json object containing user preferences</li>
<li>a hashed password if applicable (not present on google accounts)</li>
<li>a hashed password</li>
<li>a randomly generated token for providing an RSS feed of a user's subscriptions</li>
<li>a list of video IDs identifying watched videos</li>
</ul>
<p>Users can clear their watch history using the <a href="/clear_watch_history">clear watch history</a> page.</p>
<p>If a user is logged in with a Google account, no password will ever be stored. This website uses the session token provided by Google to identify a user, but does not store the information required to make requests on a user's behalf without their knowledge or consent.</p>

<h3>Data you passively provide</h3>
<p>When you request any resource from this website (for example: a page, a font, an image, or an API endpoint) information about the request may be logged.</p>
Expand Down

0 comments on commit b06c87f

Please sign in to comment.