-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hashtag API: Parse header when getting the first page #3864
base: master
Are you sure you want to change the base?
Hashtag API: Parse header when getting the first page #3864
Conversation
e23e4b6
to
6c8f9a6
Compare
Are these infos really useful? The numbers looks very approximated. |
It was mentioned in my PR to add hashtag pags to FreeTube FreeTubeApp/FreeTube#3483 (comment) @efb4f5ff-1298-471a-8973-3d47447115dc any thoughts on this? |
Sorry for the delay. So i mentioned the possibility to add this because with the stats the user knows what they are getting into. A hashtag with low amount of approximate videos could make the user go through all of them and a high amount can make the user refrain from watching too much and falling into hours of watching videos. |
Ah, I see, thanks! |
d6a93fb
to
0fc1c70
Compare
13761c9
to
c64e2f1
Compare
fd8cf49
to
0cc0670
Compare
3594b4f
to
6197b84
Compare
6197b84
to
30a8768
Compare
30a8768
to
6fbcd13
Compare
6fbcd13
to
6bf7d1e
Compare
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked. |
6bf7d1e
to
da0f0a0
Compare
Updated and working again |
8117a49
to
2098a24
Compare
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked. |
2098a24
to
7a24f45
Compare
Code is still working, I also added some tests to the description |
7a24f45
to
26f852f
Compare
26f852f
to
6218eb2
Compare
4ae86e6
to
58d294f
Compare
58d294f
to
29c0036
Compare
29c0036
to
f530817
Compare
When requesting the first page of a hashtag (without continuations), YouTube will include a hashtag header that includes info such as the # of videos and # of channels in the hashtag.
This PR will parse those properties (it also creates separate structs for the hashtag page + header)
Before
After
Page 1:
Page 2:
Tests:
go to :
/api/v1/hashtag/cat?page=1
or/api/v1/hashtag/cat
and see the header in the json responsego to
/api/v1/hashtag/cat?page=2
and no longer see the header on page 2