Proxy: Handle non-200 HTTP codes on DASH manifests #4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unixfox
approved these changes
Feb 12, 2024
SamantazFox
added
the
need-testing
|
Of course it's not blocked on the test instance 🙄 |
SamantazFox
added
in-testing
|
I had no luck at trying to get youtube to block the test instance, but I'll mark this as ready anyway, I don't see why it wouldn't work. |
SamantazFox
added
ready
and removed
in-testing
2 tasks
SamantazFox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Invidious assumes that fetching the DASH manifest from YouTube will always be successful and doesn't check the status code. That means that if it gets YouTube's ratelimiting page, it returns a response with a HTTP 200 status code,
application/dash+xmlContent-Type header and the response body being the HTML for YouTube ratelimiting page.Real world example: https://invidious.nerdvpn.de/api/manifest/dash/id/jfKfPfyJRdk
Copied from the checks that are done for the HLS manifests:
invidious/src/invidious/routes/api/manifest.cr
Lines 217 to 219 in cf68620
invidious/src/invidious/routes/api/manifest.cr
Lines 162 to 164 in cf68620