Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player: Fix playback position of already watched videos #4731

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Player: Fix playback position of already watched videos #4731

merged 1 commit into from
Jul 21, 2024

Conversation

Fijxu
Copy link
Contributor

@Fijxu Fijxu commented Jun 5, 2024 •
edited by SamantazFox
Loading

Closes #3976

Trying to watch an already watched video will make the video start 15 seconds before the end of the video. This is not very comfortable when listening to music or watching/listening playlists over and over. This can be easily tested on any instance with the "Save playback position" enabled on Preferences.

@Fijxu Fijxu requested a review from a team as a code owner June 5, 2024 15:35
@Fijxu Fijxu requested review from SamantazFox and removed request for a team June 5, 2024 15:35
SamantazFox
SamantazFox reviewed Jun 10, 2024
View reviewed changes
assets/js/player.js Outdated Show resolved Hide resolved
@Fijxu
Player: Fix video playback for videos that have already been watched.
e82c965 
Trying to watch an already watched video will make the video start 15
seconds before the end of the video. This is not very comfortable when
listening to music or watching/listening playlists over and over.
@Fijxu Fijxu force-pushed the video-playback-fix branch from 83731d5 to e82c965 Compare June 15, 2024 22:15
@SamantazFox SamantazFox added need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something in-testing This feature has been deployed and is being tested and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Jun 16, 2024
@unixfox unixfox mentioned this pull request Jun 26, 2024
Closed
@pimlie
Copy link

pimlie commented Jun 26, 2024

Thanks for the fix. Wdyt about listening on the player ended event to reset the play position? Might be a bit cleaner solution then using a fixed threshold, but not sure how/where the playback position is recorded though and if there is an api endpoint available for that.

@SamantazFox SamantazFox added ready and removed in-testing This feature has been deployed and is being tested labels Jul 21, 2024
@SamantazFox SamantazFox changed the title Player: Fix video playback for videos already watched videos. Player: Fix playback position of already watched videos Jul 21, 2024
@SamantazFox SamantazFox merged commit 09bf09b into iv-org:master Jul 21, 2024
@SamantazFox
Copy link
Member

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unixfox unixfox unixfox approved these changes

@SamantazFox SamantazFox SamantazFox approved these changes

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Disable or reset playback position for playlist and videos near end.
4 participants
@Fijxu @pimlie @SamantazFox @unixfox