Fix treetopologyex.11.cpp #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan100sic
reviewed
Jun 14, 2024
trees/treetopologyex.11.cpp
Outdated
| @@ -102,5 +102,7 @@ struct tree_topology_ex : tree_topology { | |||
| int main() { | |||
| tree_topology_ex tt({{0, 1}, {1, 2}, {1, 3}}, 3); | |||
|
|
|||
| cout << tt.kth(2, 3, 1); | |||
There was a problem hiding this comment.
Printing a value doesn't really do anything towards the result of the test. You must compare it with the expected value and return 1 if they're different.
Another idea: Since the tree in this test case is quite small, let's add a different one with say, 10 nodes, pick some two vertices whose LCA is not 0, and test every vertex on the path between them by calling kth.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the minor error and added a test case exploiting it.