Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay between batches & one more "concurrent map write" fix #160

Merged
merged 4 commits into from
May 11, 2018

Conversation

ivanilves
Copy link
Owner

@ivanilves ivanilves commented May 9, 2018

I try to avoid non-single scope PR but ...

What do we bring?

GIF

@coveralls
Copy link

coveralls commented May 10, 2018

Coverage Status

Coverage increased (+0.01%) to 97.291% when pulling 85a2485 on batch-delay into 9f60bca on master.

@vonrabbe vonrabbe changed the title feat(api/v1): Add optional delay between request batches Add delay between batches & one more "concurrent map write" fix May 11, 2018
Copy link
Collaborator

@vonrabbe vonrabbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title is not true, but OK, the PR itself LGTM

@vonrabbe
Copy link
Collaborator

I've changed the PR title BTW! We need to be more accurate in our descriptions 😉

@vonrabbe vonrabbe merged commit 109227f into master May 11, 2018
@vonrabbe vonrabbe deleted the batch-delay branch May 11, 2018 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants