fix: Do NOT require list permissions on a single set of tags #228
Conversation
ivanilves
force-pushed
the
ISSUE-222
branch
2 times, most recently
from
b159e10 to
b4f82b2
Compare
| @@ -172,8 +172,6 @@ func decodeTagData(body io.ReadCloser) ([]string, map[string]manifest.Manifest, | |||
| return nil, nil, err | |||
| } | |||
|
|
|||
| tagManifests = manifest.MapByTag(tagManifests) | |||
There was a problem hiding this comment.
this was a useless line 😆
| @@ -263,6 +263,7 @@ func ParseRef(ref string) (*Repository, error) { | |||
| refParts := strings.Split(fullRef, "=") | |||
| fullRepo = refParts[0] | |||
| repoTags = strings.Split(refParts[1], ",") | |||
| isSingle = true | |||
There was a problem hiding this comment.
a set of single tags should be also classified as "single"
| tagManifests := make(map[string]manifest.Manifest) | ||
|
|
||
| for _, tagName := range repoTags { | ||
| tagManifests[tagName] = manifest.Manifest{} |
There was a problem hiding this comment.
This would be filled later... GCR allows you to get some extra information at this step, but it's available only on list operation which we will not perform if we are looking for the set of single tags only...
|
Looks cool! I'll try and build this and try it out :D |
|
This is SO MUCH FASTER 😁 |
|
I may have spoken too soon. I think this behaves differently with a config file maybe? If I run a single instance locally it's lightning fast but when run in my environment I get this still:
|
|
First, thank you for the swift review @cablespaghetti 🙇
I think this may be related to Original issue cases were error 401 because of list requests instead of "blind" get ones 🙂 Could you please add concurrency limits for quay:
❓ P.S.: |
|
I agree @ivanilves this "429 Too Many Requests" is a separate issue 👍 |
closes #222