Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue-231): "nil *Token pointer" panic #232

Merged
merged 2 commits into from
Jul 21, 2021
Merged

fix(issue-231): "nil *Token pointer" panic #232

merged 2 commits into from
Jul 21, 2021

Conversation

ivanilves
Copy link
Owner

@ivanilves ivanilves commented Jul 21, 2021 •
edited
Loading

Fixing #231 as cli.Token may be nil, but also, since it's an interface it can be a non-nil structure with a nil value :trollface:

@coveralls
Copy link

coveralls commented Jul 21, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 91.423% when pulling 9726540 on issue-231 into 9e7844b on master.

@ivanilves ivanilves requested a review from vonrabbe July 21, 2021 05:19
@ivanilves ivanilves merged commit 1275cee into master Jul 21, 2021
@ivanilves ivanilves deleted the issue-231 branch July 21, 2021 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonrabbe vonrabbe vonrabbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanilves @coveralls @vonrabbe