Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a popup.html that will be use to turn off/on the extension #5

Open
ivedmohan opened this issue Sep 29, 2024 · 7 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ivedmohan
Copy link
Owner

So there are few websites which we want to support so we allow add blocker so instead of going in your extension add a popup.html that can have a toggle button.

@Sauhard74
Copy link

hey can i work on this issue

@ivedmohan
Copy link
Owner Author

hey can i work on this issue

You can start working on it no need to get it assigned to you

@ivedmohan ivedmohan added enhancement New feature or request good first issue Good for newcomers labels Sep 30, 2024
@ivedmohan
Copy link
Owner Author

any update @Sauhard74

@Sauhard74
Copy link

I am done working on the issue .. will be raising the pr tommorow or today evening

@iaryasharma
Copy link
Contributor

I just wanted to let you know that I’ve made some updates related to this issue in my fork of the repository. I’ve implemented a fix for the ad blocking functionality. You can find the details in my pull request here.

ivedmohan added a commit that referenced this issue Oct 3, 2024
Added popup functionality to extension as described in issue #5
@ivedmohan
Copy link
Owner Author

@Sauhard74 you can work in the css of new popup.html

@itsharshitrwt
Copy link
Contributor

Any progress with the issue ?? need any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants