-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable strict-aliasing optimizations #322
Labels
Comments
It would be good to check the source code with TypeSanitizer (TySan), but it seems not available yet.
|
ivmai
added a commit
that referenced
this issue
Oct 22, 2024
Issue #322 (bdwgc). * CMakeLists.txt (HAVE_FLAG_F_NO_STRICT_ALIASING): Remove. * CMakeLists.txt [HAVE_FLAG_F_NO_STRICT_ALIASING] (add_compile_options): Do not add -fno-strict-aliasing. * build.zig (build): Do not add "-fno-strict-aliasing" to flags; update comment. * configure.ac [$GCC=yes] (ac_cv_fno_strict_aliasing): Do not define. * configure.ac [$GCC=yes]: Do not check if -fno-strict-aliasing is supported. * configure.ac [$GCC=yes && $ac_cv_fno_strict_aliasing=yes] (CFLAGS): Do not append -fno-strict-aliasing. * docs/platforms/README.win64: Do not mention -fno-strict-aliasing. * extra/gc.c: Remove -fno-strict-aliasing from comment.
Running all existing test configs does not show any issue after removing -fno-strict-aliasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently configure and cmake scripts contain -fno-strict-aliasing. The whole source code should be reviewed regarding unsafe type casts (and checked with TypeSanitizer) to enable strict-aliasing optimizations.
The text was updated successfully, but these errors were encountered: