Add questions to start tall.

QUESTIONS.md

@@ -0,0 +1,4 @@
+* Why are you building custom cache instead of using some in-memory db (Redis, Memcached, etc)
+* Ideally docker in development builds application inside container. This way allows to not install any development tools when you develop. Can you describe steps, how to implement it.
+* Why you are using spring.jpa.open-in-view=false in configuration?  Why developers forced to set it? Why it is antipattern? (Same questions for defer-datasource-initialization: true)
+* Tests... What tests MUST be written (at least) 

src/main/java/com/atanava/locator/AuthUser.java

@@ -1,3 +1,4 @@
+/** @QUESTION: Why are you using this package? */
 package com.atanava.locator;
 
 import com.atanava.locator.model.User;

src/main/java/com/atanava/locator/config/CacheConfig.java

@@ -20,6 +20,9 @@
 
 @Slf4j
 @RequiredArgsConstructor
+/**
+ * @QUESTION: Why you don't proxy beans?
+ */
 @Configuration(proxyBeanMethods = false)
 public class CacheConfig<K, V> {
 

src/main/java/com/atanava/locator/model/Role.java

@@ -1,7 +1,7 @@
 package com.atanava.locator.model;
 
 import org.springframework.security.core.GrantedAuthority;
-
+/** @QUESTION: Why did you not set ROLE_* using constructor */
 public enum Role implements GrantedAuthority {
 	USER,
 	ADMIN;

src/main/java/com/atanava/locator/service/PointTo.java

@@ -1,3 +1,4 @@
+/** @QUESTION: Why it is here? */
 package com.atanava.locator.service;
 
 import com.atanava.locator.model.PointId;

src/main/java/com/atanava/locator/web/OsmController.java

@@ -37,6 +37,7 @@ public ResponseEntity<ArrayNode> getByAddress(@RequestParam(required = false) St
 												  @RequestParam(required = false) Integer addressdetails,
 												  @RequestParam(required = false) String format) {
 
+		/** @QUESTION: May be content negatiation will be better??? */
 		format = getFormatOrDefault(format);
 		ArrayNode created;
 		if (q != null) {