Add chooseText and cancelText properties #618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for PR. Could you prefix properties with ‘cropper’ to have consistent naming with opet cropper related properties? |
|
@ivpusic done |
|
Will this be merged? We are making an app that supports multiple languages and this feature is a must. Please! @ivpusic |
|
@pistonsky could you fix merge conflicts and I will then merge it? |
|
@ivpusic & @pistonsky - I just rebased it on master & opened a separate PR - figured that would be quicker than reaching out to @smsmdida to ask him to rebase. As a side note - thanks for great work! |
|
tnx all. merged here #699 |
Thanks. Could you translate the "Rotate" and "Scale" on edit image with android device? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added ability to change control buttons texts in crop