Negative 0.0 Handled

ivy-llc · Sep 13, 2023 · 3bb405f · 3bb405f
1 parent 5123d8e
commit 3bb405f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/docs/demos b/docs/demos
diff --git a/ivy/functional/frontends/numpy/__init__.py b/ivy/functional/frontends/numpy/__init__.py
@@ -638,6 +638,7 @@ def promote_types_of_numpy_inputs(
 
 from ivy.functional.frontends.numpy.mathematical_functions.floating_point_routines import (  # noqa
     _nextafter,
+    _signbit,
     _spacing,
 )
 

diff --git a/ivy/functional/frontends/numpy/mathematical_functions/floating_point_routines.py b/ivy/functional/frontends/numpy/mathematical_functions/floating_point_routines.py
@@ -51,10 +51,7 @@ def _signbit(
     dtype=None,
     subok=True,
 ):
-    if dtype is None:
-        dtype = ivy.dtype(x)
-    zero = ivy.zeros_like(x, dtype=dtype)
-    return ivy.less(x, zero)
+    return ivy.logical_or(ivy.less(x, 0), ivy.arctan2(0.0, x) == ivy.pi)
 
 
 @handle_numpy_out

diff --git a/...ivy/test_frontends/test_numpy/test_mathematical_functions/test_floating_point_routines.py b/...ivy/test_frontends/test_numpy/test_mathematical_functions/test_floating_point_routines.py
@@ -60,7 +60,7 @@ def test_numpy_nextafter(
     dtypes_values_casting=np_frontend_helpers.dtypes_values_casting_dtype(
         arr_func=[
             lambda: helpers.dtype_and_values(
-                available_dtypes=helpers.get_dtypes("float"),
+                available_dtypes=helpers.get_dtypes("valid"),
                 num_arrays=1,
             )
         ],