tensorflow.roll #10354
Merged
tensorflow.roll #10354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
the
TensorFlow Frontend
|
@Nightcrab Could you help out on why my tests are failing |
Nightcrab
suggested changes
Feb 14, 2023
|
|
||
|
|
||
| def roll(input, shift, axis, name=None): | ||
| return ivy.roll(input, shift, axis) |
There was a problem hiding this comment.
axis is keyword only, see the ivy doc:
https://lets-unify.ai/ivy/functional/ivy/manipulation/roll/roll_functional.html?highlight=*
so this should be
axis=axis
| fn_tree=fn_tree, | ||
| on_device=on_device, | ||
| input=value[0], | ||
| shifts=shift, |
There was a problem hiding this comment.
shifts should be shift, and dims should be axis.
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 17, 2023
* tensorflow.roll implementation * code formating * added required changes
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 23, 2023
* tensorflow.roll implementation * code formating * added required changes
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
* tensorflow.roll implementation * code formating * added required changes
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
* tensorflow.roll implementation * code formating * added required changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.