Update layers.py added max_pool1d class #15444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the test case for max_pool1d
Co-authored-by: Sam Armstrong <88863522+Sam-Armstrong@users.noreply.github.com>
|
claose #15444 |
|
Hello @mtnvdsk! Thanks for opening this PR. Would you please link the issue that this PR closes in the description? Thanks :) |
|
@hello-fri-end sir, updated the description |
|
@hello-fri-end sir, all the test cases are passing except the jax test case. please guide me to correct the code. |
CatB1t
suggested changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement stateful classes for stateful layers #14945