Updated Max pool1d #15776
Updated Max pool1d #15776
Conversation
|
close #15776 |
|
sir @kurshakuz , All the test cases are passing except a jax test case failure could you please guide me to rectify the error and code. |
| kernel = [] | ||
| new_kernel = [] | ||
| dilations = [] | ||
|
|
||
| for i in range(array_dim): | ||
| if i + 1 < len(in_shape): | ||
| kernel.append(draw(st.integers(1, in_shape[i+1]))) | ||
| else: | ||
| kernel.append(draw(st.integers(1, 10))) # Replace 10 with an appropriate maximum value | ||
|
|
||
| if return_dilation: | ||
| if kernel[i] > 1: | ||
| max_dilation = (in_shape[i + 1] - kernel[i]) // (kernel[i] - 1) + 1 | ||
| max_dilation = (in_shape[i+1] - kernel[i]) // (kernel[i] - 1) + 1 | ||
| dilations.append(draw(st.integers(1, max_dilation))) | ||
| new_kernel.append(kernel[i] + (kernel[i] - 1) * (dilations[i] - 1)) | ||
| new_kernel.append(kernel[i] + (kernel[i] - 1) * (dilations[i-1] - 1)) |
There was a problem hiding this comment.
Hello @mtnvdsk , can you please explain the rationale behind those changes? what is the bug/issue you're trying to fix?
|
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
1 similar comment
|
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
|
This PR has been closed because it has been marked as stale for more than 7 days with no activity. |
Adding max_pool1d #15775