Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for ivy.Array and ivy.NativeArray inputs to the split functions #15800

Merged
merged 23 commits into from
May 30, 2023
Merged

Adding support for ivy.Array and ivy.NativeArray inputs to the split functions #15800

merged 23 commits into from
May 30, 2023

Conversation

fnhirwa
Copy link
Contributor

@fnhirwa fnhirwa commented May 23, 2023 •
edited
Loading

Adding the support of 1-D Array for num_or_size_splits for a superset behaviour as Numpy supports this argument to be ndarray. and reduce re-implementation of functions like vsplit and hsplit and fixing current tests as they are failing

Checklist:

  • ivy.split
  • ivy.vsplit
  • ivy.hsplit
  • ivy.dsplit
  • Numpy frontend
    • split
    • vsplit
    • hsplit
    • dsplit
  • Jax Frontend
    • split
    • vsplit
    • hsplit
    • dsplit
  • Torch Frontend
    • split
    • vsplit
    • hsplit
    • dsplit
  • TensorFlow Frontend
    • split

@fnhirwa fnhirwa changed the title WIP Adding support for ivy.Array and ivy.NativeArray inputs to the split functions [WIP] Adding support for ivy.Array and ivy.NativeArray inputs to the split functions May 23, 2023
@fnhirwa fnhirwa marked this pull request as draft May 23, 2023 14:21
@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Paddle Paddle Backend labels May 23, 2023
@ivy-leaves ivy-leaves added Ivy Functional API NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist labels May 23, 2023
@fnhirwa fnhirwa marked this pull request as ready for review May 30, 2023 07:45
@fnhirwa fnhirwa changed the title [WIP] Adding support for ivy.Array and ivy.NativeArray inputs to the split functions Adding support for ivy.Array and ivy.NativeArray inputs to the split functions May 30, 2023
@fnhirwa fnhirwa merged commit dd1bfc5 into ivy-llc:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MahmoudAshraf97 MahmoudAshraf97

Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fnhirwa @MahmoudAshraf97 @ivy-leaves