add numpy spacing frontend function #16436

OziomaEunice · 2023-06-08T14:53:39Z

Including comments to provided clarity on the code

radian
arctan2
hypot

Including comments to provided clarity on the code - radian - arctan2 - hypot

OziomaEunice · 2023-06-09T09:25:37Z

@juliagsy I have made some updates to the code in the trigonometry python file for the NumPy Frontend pull request. The changes include more additional trigonometry functions, and I added comments to provide clarity.

Could you please review the updated code and provide feedback? I would appreciate your guidance to ensure the changes meet the required standards.

Thank you in advance for your time and assistance.

juliagsy

Hello! Thanks for the changes! We actually have a list of open tasks here, where you can then find the todo lists in the repo's GitHub issues. You'll then need to select an available function to work on for the frontends category.

As for the docstrings, they actually don't apply here as this is the frontends, and the functions are identical to their native function, therefore self-explanatory through their native documentation and would be redundant to add docstrings here.

As for the functions you've added/implemented, please first make sure that they are available in the todo list (not marked as completed or ticked in the todo), more information in the open tasks section of the documentation, https://unify.ai/docs/ivy/overview/contributing/open_tasks.html

Thanks!

approx_min_k added to lax/operators.py

approx_min_k function added to lax/operators.py

OziomaEunice · 2023-06-12T10:16:08Z

Hi @juliagsy, thank you for your response. I wanted to let you know that I have made some updates to the code. I have removed the docstrings from it.

Additionally, before starting to work on the file, I did select a task from the ToDo list, specifically the 'spacing' task, as I noticed that it was still available and hadn't been assigned to anyone else. I hope this clears up any confusion.

Thank you in advance.

juliagsy · 2023-06-14T08:59:34Z

@OziomaEunice Thanks for the clarification! Did you have an issue for that? Could you please link it in the PR or comment with the issue? Thanks a lot!

OziomaEunice · 2023-06-14T09:27:43Z

@juliagsy I just found out there was an error on my part, I chose the 'spacing' task but instead I did radian, arctan2 and hypot :( !
In any case this is where I got the issue from:

Add Mathematical functions to Numpy Frontend Add Mathematical functions to Numpy Frontend #1525

While the ToDo (Sub-task) is:

spacing spacing #16433

I've corrected this by adding the spacing function in the floating_point_routines.py file. Also, I've sent another PR. Kindly see the update.

Cheers!

Added Spacing function to floating_point_routines.py file and test case in the test_floating_point_routines.py file

juliagsy · 2023-06-15T14:34:56Z

@OziomaEunice Thanks for clarifying! I see you mention sending a new PR, would you mind to either maybe open a new one which consists of only the spacing function and test, or clean this PR up to contain only that? Thanks a lot!

Update: 1. Removed my code from the trigonometric_functions.py file 2. Spacing function now the one included in the floating_point_routines.py file

OziomaEunice · 2023-06-15T20:02:21Z

I made 2 new PR which now contain the 'spacing' function and its test.

juliagsy · 2023-06-16T05:59:41Z

@OziomaEunice Ahh I see, thanks for the clarification! Since both PRs are about the same changes, would you mind to keep only the newer one of them to avoid duplicates? Thanks a lot!

OziomaEunice · 2023-06-16T06:42:08Z

@juliagsy Ok, I've kept this one here, and removed the other duplicate.

OziomaEunice · 2023-06-16T07:06:16Z

Do I merge the branch or is it up to you to do it?

Thanks.

juliagsy

Hey! Thanks for contributing! I've left some comments below, feel free to ping me if there's any issue, thanks!

juliagsy · 2023-06-16T07:04:07Z

ivy/functional/frontends/jax/lax/operators.py

@@ -626,3 +626,13 @@ def conj(x):
 @to_ivy_arrays_and_back
 def is_finite(x):
    return ivy.isfinite(x)
+
+
+# approx_min_k


please remove this function as it is not related to the spacing function

juliagsy · 2023-06-16T07:04:28Z

ivy/functional/frontends/numpy/mathematical_functions/floating_point_routines.py

@@ -10,7 +10,8 @@
    handle_numpy_casting,
 )

-
+# This is the nextafter function.


comment not needed

juliagsy · 2023-06-16T07:04:35Z

ivy/functional/frontends/numpy/mathematical_functions/floating_point_routines.py

+
+
+
+# This is the spacing function.


comment not needed

juliagsy · 2023-06-16T07:05:59Z

ivy/functional/frontends/numpy/mathematical_functions/floating_point_routines.py

+    dtype=None,
+    subok=True,
+):
+    return ivy.spacing(x, out=out) # Return result


the spacing function is not yet available in the ivy functional API, please either implement this frontend function through compositions, or in other cases, propose the function to be implemented in the ivy API, more info here: https://unify.ai/docs/ivy/overview/contributing/open_tasks.html#ivy-experimental-api

Thanks @juliagsy ! In place of

return ivy.spacing(x, out=out)

I replaced it with # Implement the frontend function using Ivy compositions spacing = ivy.subtract(ivy.nextafter(ivy.abs(x), ivy.sign(x)), x) return spacing .

Is that ok?

OziomaEunice · 2023-06-16T07:46:12Z

@juliagsy Updates made:

Removed comments from files as you suggested
Replaced return ivy.spacing(x, out=out) with spacing = ivy.subtract(ivy.nextafter(ivy.abs(x), ivy.sign(x)), x) return spacing
Removed a function in the operations.py file that was not related to the spacing function.

juliagsy

Hey! Thanks for the changes so far! If the tests are passing, the approach is fine. Another addition required is in the ivy/frontends/numpy/init.py file. Please import the namespaces at the appropriate location.

around line 631
around line 713

Could you please update your fork/branch so that it is latest as ivy master as well? Thanks a lot!

OziomaEunice · 2023-06-20T06:42:51Z

@juliagsy I've done the updates as requested.

Cheers :)

OziomaEunice · 2023-06-21T20:08:12Z

@juliagsy are you able to solve the conflicting files? The only thing showing that is conflicting is the addition of spacing function in the init.py file.

OziomaEunice · 2023-06-22T06:59:49Z

Hey thanks @juliagsy ! Do I commit the branch or will you be able to do it?

juliagsy · 2023-06-22T07:20:20Z

Hey @OziomaEunice ! The imports should be fine now!
I was diving into the implementation as the tests weren't passing, the implementation should be this:

if dtype is None:
        dtype = ivy.dtype(x)
    y = ivy.floor(ivy.log2(ivy.abs(x + 1)))
    spacing = ivy.multiply(ivy.finfo(dtype).eps, ivy.pow(2, y))
    if dtype != "float16":
        spacing = ivy.sign(x) * spacing
    return spacing

I've tested and they should be passing, but feel free to verify them again, please ping me when the related changes are done! Thanks!

juliagsy · 2023-06-22T07:21:43Z

Oh! And one last thing, you'll need to set these in the test_frontend_function arguments:

....
        rtol=1e-03,
        atol=1e-03,
....

OziomaEunice · 2023-06-22T07:22:52Z

@juliagsy no worries, I'll do that and push the code in few minutes

OziomaEunice · 2023-06-22T07:23:34Z

Hey @OziomaEunice ! The imports should be fine now! I was diving into the implementation as the tests weren't passing, the implementation should be this:
if dtype is None:
        dtype = ivy.dtype(x)
    y = ivy.floor(ivy.log2(ivy.abs(x + 1)))
    spacing = ivy.multiply(ivy.finfo(dtype).eps, ivy.pow(2, y))
    if dtype != "float16":
        spacing = ivy.sign(x) * spacing
    return spacing
I've tested and they should be passing, but feel free to verify them again, please ping me when the related changes are done! Thanks!

Also, do I need to put this code in a file? And if so, where?

juliagsy · 2023-06-22T07:25:20Z

@OziomaEunice this should be the complete function body for spacing thanks!

OziomaEunice · 2023-06-22T07:27:19Z

@OziomaEunice this should be the complete function body for spacing thanks!

Sorry...again just for clarification, do I add it to the _spacing function?

Also, which lines do I add this in the test_floating_point_routines.py:

rtol=1e-03, atol=1e-03, ?

juliagsy · 2023-06-22T07:29:55Z

@OziomaEunice yep, that's right! to be specific, it should look like this, thanks!:

@handle_numpy_out
@handle_numpy_dtype
@to_ivy_arrays_and_back
@handle_numpy_casting
@from_zero_dim_arrays_to_scalar
def _spacing(
    x,
    /,
    out=None,
    *,
    where=True,
    casting="same_kind",
    order="K",
    dtype=None,
    subok=True,
):
    if dtype is None:
        dtype = ivy.dtype(x)
    y = ivy.floor(ivy.log2(ivy.abs(x + 1)))
    spacing = ivy.multiply(ivy.finfo(dtype).eps, ivy.pow(2, y))
    if dtype != "float16":
        spacing = ivy.sign(x) * spacing
    return spacing

OziomaEunice · 2023-06-22T07:31:15Z

Thank you! I've update the code now. What remains is this:

rtol=1e-03,

atol=1e-03,

But in which lines do I place this in the test_floating_point_routines.py?

juliagsy · 2023-06-22T07:33:31Z

no problem!
the function used in testing, so after the change, the function arguments should look like this:

np_frontend_helpers.test_frontend_function(
        input_dtypes=input_dtypes,
        frontend=frontend,
        test_flags=test_flags,
        fn_tree=fn_tree,
        on_device=on_device,
        rtol=1e-03,
        atol=1e-03,
        x=xs[0],
        out=None,
        where=where,
        casting=casting,
        order="K",
        dtype=dtype,
        subok=True,
    )

OziomaEunice · 2023-06-22T07:43:21Z

@juliagsy all the files have been updated.

juliagsy · 2023-06-22T07:53:21Z

@OziomaEunice I'll wait for the final CI test to complete its run, if everything looks good, I'll go ahead and merge it, thanks again!

OziomaEunice · 2023-06-22T08:04:17Z

@juliagsy No problem, thanks again!

juliagsy · 2023-06-22T08:09:48Z

Thanks for contributing!

Addition of Trigonometry functions numpy frontend:

d0cc745

Including comments to provided clarity on the code - radian - arctan2 - hypot

ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Jun 8, 2023

ivy-seed assigned juliagsy Jun 8, 2023

juliagsy reviewed Jun 12, 2023

View reviewed changes

Operator functions to Jax Frontend: approx_min_k

28f5128

approx_min_k added to lax/operators.py

ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Jun 12, 2023

OziomaEunice added 4 commits June 12, 2023 09:44

Operator functions to Jax Frontend: approx_min_k

db334fc

approx_min_k function added to lax/operators.py

Added approx_min_k function to Jax Frontend

b30f698

Docstring removed

499e0f5

Docstring removed

53a81ec

OziomaEunice added 2 commits June 14, 2023 10:47

Added Spacing function to floating_point_routines

991ebea

Added Spacing function to floating_point_routines

fe4a312

Added Spacing function to floating_point_routines.py file and test case in the test_floating_point_routines.py file

Added Spacing function to floating_point_routines

dc16248

Update: 1. Removed my code from the trigonometric_functions.py file 2. Spacing function now the one included in the floating_point_routines.py file

juliagsy suggested changes Jun 16, 2023

View reviewed changes

juliagsy changed the title ~~Addition of Trigonometry functions numpy frontend:~~ add numpy spacing frontend function Jun 16, 2023

OziomaEunice added 2 commits June 16, 2023 08:36

spacing function

182d069

a function not related to spacing removed

95493e8

juliagsy suggested changes Jun 20, 2023

View reviewed changes

OziomaEunice added 2 commits June 20, 2023 07:38

Merge branch 'master' into oziomaeunice-ivy

106dc0b

import namespaces

06172ca

Merge branch 'master' into oziomaeunice-ivy

779367c

updates to ivy numpy floating point routines

17ce4c4

juliagsy merged commit ce18a84 into ivy-llc:master Jun 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add numpy spacing frontend function #16436

add numpy spacing frontend function #16436

OziomaEunice commented Jun 8, 2023 •

edited by juliagsy

Loading

OziomaEunice commented Jun 9, 2023

juliagsy left a comment

OziomaEunice commented Jun 12, 2023 •

edited

Loading

juliagsy commented Jun 14, 2023

OziomaEunice commented Jun 14, 2023 •

edited

Loading

juliagsy commented Jun 15, 2023

OziomaEunice commented Jun 15, 2023

juliagsy commented Jun 16, 2023

OziomaEunice commented Jun 16, 2023 •

edited

Loading

OziomaEunice commented Jun 16, 2023

juliagsy left a comment

juliagsy Jun 16, 2023

juliagsy Jun 16, 2023

juliagsy Jun 16, 2023

juliagsy Jun 16, 2023

OziomaEunice Jun 16, 2023 •

edited

Loading

OziomaEunice commented Jun 16, 2023 •

edited

Loading

juliagsy left a comment

OziomaEunice commented Jun 20, 2023 •

edited

Loading

OziomaEunice commented Jun 21, 2023

OziomaEunice commented Jun 22, 2023 •

edited

Loading

juliagsy commented Jun 22, 2023

juliagsy commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023

juliagsy commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023 •

edited

Loading

juliagsy commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023 •

edited

Loading

juliagsy commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023 •

edited

Loading

juliagsy commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023

juliagsy commented Jun 22, 2023

add numpy spacing frontend function #16436

add numpy spacing frontend function #16436

Conversation

OziomaEunice commented Jun 8, 2023 • edited by juliagsy Loading

OziomaEunice commented Jun 9, 2023

juliagsy left a comment

Choose a reason for hiding this comment

OziomaEunice commented Jun 12, 2023 • edited Loading

juliagsy commented Jun 14, 2023

OziomaEunice commented Jun 14, 2023 • edited Loading

juliagsy commented Jun 15, 2023

OziomaEunice commented Jun 15, 2023

juliagsy commented Jun 16, 2023

OziomaEunice commented Jun 16, 2023 • edited Loading

OziomaEunice commented Jun 16, 2023

juliagsy left a comment

Choose a reason for hiding this comment

juliagsy Jun 16, 2023

Choose a reason for hiding this comment

juliagsy Jun 16, 2023

Choose a reason for hiding this comment

juliagsy Jun 16, 2023

Choose a reason for hiding this comment

juliagsy Jun 16, 2023

Choose a reason for hiding this comment

OziomaEunice Jun 16, 2023 • edited Loading

Choose a reason for hiding this comment

OziomaEunice commented Jun 16, 2023 • edited Loading

juliagsy left a comment

Choose a reason for hiding this comment

OziomaEunice commented Jun 20, 2023 • edited Loading

OziomaEunice commented Jun 21, 2023

OziomaEunice commented Jun 22, 2023 • edited Loading

juliagsy commented Jun 22, 2023

juliagsy commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023

juliagsy commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023 • edited Loading

juliagsy commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023 • edited Loading

juliagsy commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023 • edited Loading

juliagsy commented Jun 22, 2023

OziomaEunice commented Jun 22, 2023

juliagsy commented Jun 22, 2023

OziomaEunice commented Jun 8, 2023 •

edited by juliagsy

Loading

OziomaEunice commented Jun 12, 2023 •

edited

Loading

OziomaEunice commented Jun 14, 2023 •

edited

Loading

OziomaEunice commented Jun 16, 2023 •

edited

Loading

OziomaEunice Jun 16, 2023 •

edited

Loading

OziomaEunice commented Jun 16, 2023 •

edited

Loading

OziomaEunice commented Jun 20, 2023 •

edited

Loading

OziomaEunice commented Jun 22, 2023 •

edited

Loading

OziomaEunice commented Jun 22, 2023 •

edited

Loading

OziomaEunice commented Jun 22, 2023 •

edited

Loading

OziomaEunice commented Jun 22, 2023 •

edited

Loading