Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added atanh tensor instance method and test to PaddlePaddle frontend #16438

Merged
merged 16 commits into from
Jul 20, 2023

Conversation

sachelsout
Copy link
Contributor

Close #15908

@sachelsout
Copy link
Contributor Author

Hello @zhumakhan , could you please review my PR ?

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Jun 19, 2023
@sachelsout
Copy link
Contributor Author

Hello @zhumakhan , could you please review my PR ?

@zhumakhan
Copy link
Contributor

Hi, thanks for you PR! It seems you've also added amax method, could you please remove that? Also please resolve the conflicts. Probably then we can merge it.
Thanks!

@sachelsout
Copy link
Contributor Author

Hi, thanks for you PR! It seems you've also added amax method, could you please remove that? Also please resolve the conflicts. Probably then we can merge it. Thanks!

Sure @zhumakhan , I'll do the required changes right away !! 😃

@sachelsout
Copy link
Contributor Author

Hi @zhumakhan , could you please review my PR ?

@sachelsout
Copy link
Contributor Author

sachelsout commented Jul 2, 2023

@zhumakhan , I tried to resolve merge conflicts and ran tests locally to which I am getting error as mentioned below 👇
image
This 'cpu' KeyError is observed in most of the functions already implemented in different directories. Same issue was faced earlier for jax framework and the issue was resolved from Ivy's end.
So let's wait to get this resolved and then I'll resolve merge conflicts !! 😃

@sachelsout
Copy link
Contributor Author

Hi @zhumakhan , I made some changes in the code (updated paddle version to 2.5.0 in tensor.py function) and the test cases are passing now for atanh function ! 😃
Update - I tried running the test cases again and it is failing for tensorflow backend, other tests are passing.
Could you please let me know what I can do to resolve this issue. Thank You !!

Here is the error screenshot -
image

@sachelsout
Copy link
Contributor Author

@zhumakhan , Quick update !!
After I resolved merge conflicts, I tried running test cases and all the test cases are passing now. 😄
image

@sachelsout
Copy link
Contributor Author

Hi @zhumakhan , could you please review my PR ? 😃

@zhumakhan zhumakhan merged commit c9f7418 into ivy-llc:master Jul 20, 2023
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atanh
3 participants