Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added log10 to ivy paddle frontend (#16507) #16528

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

JagjeetSunghera
Copy link
Contributor

#16507 completed

@JagjeetSunghera
Copy link
Contributor Author

dear @Ookamice, please review my PR, i think there is some issue with run_test(1). all PRs are suffering from it.

Copy link
Contributor Author

@JagjeetSunghera JagjeetSunghera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@Ookamice
Copy link
Contributor

@JagjeetSunghera
Hiya, thank you for your contributions. From an initial look, the logic appears to be perfect. I'll run your testcase in a github codespace due to the intelligent-test-pr's bugs. I'll let you know the result! 🚀

@Ookamice
Copy link
Contributor

Ran the test and they all passed except for jax but I believe it has to do with ivy.log10's backend implementation and not your frontend logic. Thank you for your work!! 😄

@Ookamice Ookamice merged commit a201fb1 into ivy-llc:master Jun 12, 2023
@JagjeetSunghera JagjeetSunghera deleted the feature branch June 12, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants