Implemented and tested Rot90 for Paddle frontends #17708
Conversation
|
Close #16746 |
ivy-leaves
added
the
Paddle Frontend
|
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
|
Hi! @DragosStoican Could you please help me check about my code? |
| init_tree="paddle.to_tensor", | ||
| method_name="rot90", | ||
| dtype_m_k_axes=_get_dtype_values_k_axes_for_rot90( | ||
| available_dtypes=helpers.get_dtypes("numeric"), |
There was a problem hiding this comment.
We should be ideally testing for all valid dtypes, and not only a subset.
There was a problem hiding this comment.
The numeric has included float, integer, bool types that are all supported by Rot90. you can check https://docs.python.org/3/library/stdtypes.html#numeric-types-int-float-complex. Please free free to ask me any questions. Thank you!
There was a problem hiding this comment.
There was a problem hiding this comment.
Hi @XinyuanWang283 we would prefer to use the argument "valid" in the helpers.get_dtypes function. When using the "valid" argument the tests are created according to the supported dtypes you've defined with the decorator
@with_supported_dtypes.
There was a problem hiding this comment.
Thank you very much for your guidance. @DragosStoican Sorry, I made a mistake. I have fixed it. Could you help me review it again. Thanks!
|
Thank you very much for your contribution and cooperation @XinyuanWang283. I'm happy to get this merged now! |
Close#16746