Reciprocal #17879
Reciprocal #17879
Conversation
ivy-leaves
added
the
Paddle Frontend
There was a problem hiding this comment.
Hi @samthakur587,
I have requested some changes below, kindly try fixing the errors and request a review from me when the tests are passing!
Feel free to ask any questions.
Thanks! 🙂
| @@ -276,3 +276,7 @@ def greater_than(self, y, name=None): | |||
| @with_supported_dtypes({"2.5.0 and below": ("float32", "float64")}, "paddle") | |||
| def rsqrt(self, name=None): | |||
| return ivy.reciprocal(ivy.sqrt(self._ivy_array)) | |||
|
|
|||
| @with_unsupported_dtypes({"2.5.0 and below": ("float16", "bfloat16")}, "paddle") | |||
There was a problem hiding this comment.
This is failing for "int16" as it is not supported by paddle, you will probably come across more unsupported dtypes failures after adding this
There was a problem hiding this comment.
Hey @zaeemansari70 i am getting this error while testing the method. i am using pytest in vscode (wsl2-ubuntu-20.04). is there any different command to run test in cli.
thank you
|
hey @zaeemansari70 i changed the data type. now it,s passing all tests in my local. now its ready to merge. if any changes required please let me know. thank you |
|
hey @zaeemansari70 solved the merge conflict. Now it's Ready to merge. thank you |
Close #17736