Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paddle frontend Tensor isclose instance method #18132

Merged
merged 2 commits into from
Jul 2, 2023
Merged

paddle frontend Tensor isclose instance method #18132

merged 2 commits into from
Jul 2, 2023

Conversation

MuhammadNizamani
Copy link
Contributor

Closed #18130

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Jul 1, 2023
@Sam-Armstrong Sam-Armstrong changed the title EHN: adding isclose in padddle tesnor.py add paddle.Tensor isclose instance method Jul 2, 2023
@Sam-Armstrong Sam-Armstrong changed the title add paddle.Tensor isclose instance method paddle frontend Tensor isclose instance method Jul 2, 2023
Sam-Armstrong
Sam-Armstrong approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@Sam-Armstrong Sam-Armstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @MuhammadNizamani 😊

@Sam-Armstrong Sam-Armstrong merged commit af81106 into ivy-llc:master Jul 2, 2023
60 of 68 checks passed
@MuhammadNizamani MuhammadNizamani deleted the isclose branch July 2, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sam-Armstrong Sam-Armstrong Sam-Armstrong approved these changes

Assignees

@Sam-Armstrong Sam-Armstrong

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isclose
3 participants
@MuhammadNizamani @Sam-Armstrong @ivy-leaves