-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fftshift to jax frontend #20857
add fftshift to jax frontend #20857
Conversation
Thanks for contributing, will check this soon! |
Could you please comment |
removed `ivy.concat` call.
Frontend Task ChecklistIMPORTANT NOTICE 🚨:The Ivy Docs represent the ground truth for the task descriptions and this checklist should only be used as a supplementary item to aid with the review process. Please note that the contributor is not expected to understand everything in the checklist. It's mainly here for the reviewer to make sure everything has been done correctly 🙂 LEGEND 🗺:
CHECKS 📑:
|
from ivy.functional.frontends.jax.func_wrapper import to_ivy_arrays_and_back | ||
|
||
|
||
@to_ivy_arrays_and_back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this decorator as the tests are failing with paddle due to unsupported dtypes@with_unsupported_dtypes({"2.4.2 and below": ("float16", "bfloat16")}, "paddle")
Sorry for the delayed review, LGTM with the change, and once you resolve the conflicts, there shouldn't be other issues and the tests would pass. |
Hi @aparajith21! Thank you for the feedback. I have made the necessary changes. I hope this is ready to merge. |
available_dtypes=helpers.get_dtypes("valid"), shape=(4,), array_api_dtypes=True | ||
), | ||
) | ||
def test_jax_numpy_fttshift( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def test_jax_numpy_fftshift
minor typo fix please
Hi @aparajith21. I feel this should do it. |
LGTM, thanks for contributing! |
Greetings!
Added fftshift to jax frontend. Tests seem to be passing. Please review the PR and let me know if any changes are needed.
🙂
This PR will close #20853