Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fftshift to jax frontend #20857

Merged
merged 5 commits into from
Aug 3, 2023
Merged

add fftshift to jax frontend #20857

merged 5 commits into from
Aug 3, 2023

Conversation

hnhparitosh
Copy link
Contributor

Greetings!
Added fftshift to jax frontend. Tests seem to be passing. Please review the PR and let me know if any changes are needed.
🙂
This PR will close #20853

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Jul 26, 2023
@aparajith21
Copy link
Contributor

Thanks for contributing, will check this soon!

@aparajith21
Copy link
Contributor

Could you please comment add_frontend_checklist and tick off the items there!

removed `ivy.concat` call.
@hnhparitosh
Copy link
Contributor Author

hnhparitosh commented Jul 27, 2023

Frontend Task Checklist

IMPORTANT NOTICE 🚨:

The Ivy Docs represent the ground truth for the task descriptions and this checklist should only be used as a supplementary item to aid with the review process.

Please note that the contributor is not expected to understand everything in the checklist. It's mainly here for the reviewer to make sure everything has been done correctly 🙂

LEGEND 🗺:

  • ❌ : Check item is not completed.
  • ✅ : Check item is ready for review.
  • 🆘 : Stuck/Doubting implementation (PR author should add comments explaining why).
  • ⏩ : Check is not applicable to function (skip).
  • 🆗 : Check item is implemented and does not require any edits.

CHECKS 📑:

    • ❌: The function/method definition is not missing any of the original arguments.
    • ❌: In case the function/method to be implemented is an alias of an existing function/method:
        • ❌: It is being declared as such by setting fun1 = fun2, rather than being re-implemented from scratch.
        • ❌: The alias is added to the existing function/method's test in the aliases parameter of handle_frontend_test/handle_frontend_method.
    • ❌: The naming of the function/method and its arguments exactly matches the original.
    • ❌: No defined argument is being ignored in the function/method's implementation.
    • ❌: In special cases where an argument's implementation should be pending due to an incomplete superset of an ivy function:
        • ❌: A ToDo comment has been added prompting to pass the frontend argument to the ivy function whose behavior is to be extended.
    • ❌: In case a frontend function is being added:
        • ❌: It is a composition of ivy functions.
        • ❌: In case the needed composition is long (using numerous ivy functions), a Missing Function Suggestion issue has been opened to suggest a new ivy function should be added to shorten the frontend implementation.
        • ❌: @to_ivy_arrays_and_back has been added to the function.
    • ❌: In case a frontend method is being added:
        • ❌: It is composed of existing frontend functions or methods.
        • ❌: If a required frontend function has not yet been added, the method may be implemented as a composition of ivy functions, making sure that:
          • ❌: @to_ivy_arrays_and_back has been added to the method.
          • ❌: A ToDo comment has been made prompting to remove the decorator and update the implementation as soon as the missing function has been added.
    • ❌: The function/method's test has been added (except in the alias case mentioned in <2>):
        • ❌: All supported arguments are being generated in handle_frontend_test/handle_frontend_method and passed to test_frontend_function/test_frontend_method.
        • ❌: The argument generation covers all possible supported values. Array sizes, dimensions, and axes adhere to the full supported set of the original function/method.
        • ❌: The available_dtypes parameter passed to the helper generating the function/method's input array is set to helpers.get_dtypes("valid"). If there are unsupported dtypes that cause the test to fail, they should be handled by adding @with_supported_dtypes/@with_unsupported_dtype to the function/method.
    • ❌: The PR is not introducing any test failures.
        • ❌: The lint checks are passing.
        • ❌: The implemented test is passing for all backends.
    • ❌: The PR closes a Sub Task issue linked to one of the open frontend ToDo lists.
    • ❌: The function/method and its test have been added to the correct .py files corresponding to the addressed ToDo list.
    • ❌: The PR only contains changes relevant to the addressed subtask.

from ivy.functional.frontends.jax.func_wrapper import to_ivy_arrays_and_back


@to_ivy_arrays_and_back
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this decorator as the tests are failing with paddle due to unsupported dtypes@with_unsupported_dtypes({"2.4.2 and below": ("float16", "bfloat16")}, "paddle")

@aparajith21
Copy link
Contributor

Sorry for the delayed review, LGTM with the change, and once you resolve the conflicts, there shouldn't be other issues and the tests would pass.

@hnhparitosh
Copy link
Contributor Author

hnhparitosh commented Jul 31, 2023

Hi @aparajith21! Thank you for the feedback. I have made the necessary changes. I hope this is ready to merge.

available_dtypes=helpers.get_dtypes("valid"), shape=(4,), array_api_dtypes=True
),
)
def test_jax_numpy_fttshift(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def test_jax_numpy_fftshift minor typo fix please

@hnhparitosh
Copy link
Contributor Author

Hi @aparajith21. I feel this should do it.

@aparajith21
Copy link
Contributor

LGTM, thanks for contributing!

@aparajith21 aparajith21 merged commit 775ed27 into ivy-llc:master Aug 3, 2023
129 of 133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fftshift
3 participants