Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

choer: add addmv_ to tensor #20998

Closed
wants to merge 0 commits into from
Closed

choer: add addmv_ to tensor #20998

wants to merge 0 commits into from

Conversation

a0m0rajab
Copy link
Contributor

Closes #20959

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Jul 29, 2023
@a0m0rajab a0m0rajab requested a review from fnhirwa July 31, 2023 20:47
fnhirwa
fnhirwa suggested changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey would you update your branch with the latest changes for the tests to run😊

@a0m0rajab
Copy link
Contributor Author

@hirwa-nshuti do you mean to merge it to master?
Cause right now it's showing me it's up to date tho

@a0m0rajab
Copy link
Contributor Author

@hirwa-nshuti pushed an empty commit to run tests again.

@fnhirwa
Copy link
Contributor

fnhirwa commented Aug 2, 2023

@hirwa-nshuti pushed an empty commit to run tests again.

What I meant is fetching upstream changes from main repository and update your branch to it

@a0m0rajab a0m0rajab closed this Aug 2, 2023
@a0m0rajab a0m0rajab mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnhirwa fnhirwa fnhirwa requested changes

@guillesanbri guillesanbri Awaiting requested review from guillesanbri

@CatB1t CatB1t Awaiting requested review from CatB1t

@vedpatwardhan vedpatwardhan Awaiting requested review from vedpatwardhan

Assignees

@fnhirwa fnhirwa

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addmv_
3 participants
@a0m0rajab @fnhirwa @ivy-leaves