Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For double sided maxwell #21264
For double sided maxwell #21264
Changes from 3 commits
61eb64a
6de1fab
3ffc3a2
f595461
d411f4c
782d92a
828967a
26faa05
dad2937
0d6cda4
99a59b4
3071a0d
453f4bb
867038b
ac7ace0
2fb7d3e
22f0d41
e1f6dc1
e10a98d
a2b7231
465cb10
fa4181c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are specifying the dtype here, this should be
valid
dtype and the dtypes that should be skipped should be added in the decorator above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and pass in
valid
here, so that the decorator skips the dtypes which are not to be tested on. Rather than us trying to restrict those in the tests.