Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vflip_lintcheck #21419

Merged
merged 2 commits into from
Aug 10, 2023
Merged

vflip_lintcheck #21419

merged 2 commits into from
Aug 10, 2023

Conversation

ManoBharathi93
Copy link
Contributor

Closes #21337

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 7, 2023
@ManoBharathi93
Copy link
Contributor Author

ManoBharathi93 commented Aug 8, 2023 •
edited
Loading

image
@MahmoudAshraf97 Above Screen shot Tested locally and combined results from display_test_results also good..
kindly verify and merge this PR as soon as possible Thank You ⭐

MahmoudAshraf97
MahmoudAshraf97 suggested changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@MahmoudAshraf97 MahmoudAshraf97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Your implementation is correct, fix the points mentioned in the review and we will be ready to merge

ivy_tests/test_ivy/test_frontends/test_paddle/test_vision/test_transforms.py Outdated Show resolved Hide resolved
@MahmoudAshraf97 MahmoudAshraf97 merged commit 618e154 into ivy-llc:master Aug 10, 2023
260 of 266 checks passed
@ManoBharathi93
Copy link
Contributor Author

Thanks for the support and guidance @MahmoudAshraf97 ..😇💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahmoudAshraf97 MahmoudAshraf97 MahmoudAshraf97 approved these changes

Assignees

@MahmoudAshraf97 MahmoudAshraf97

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vflip
3 participants
@ManoBharathi93 @MahmoudAshraf97 @ivy-leaves