Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the failing tests for the trunc method in PyTorch frontend. #21452

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fixed the failing tests for the trunc method in PyTorch frontend. #21452

merged 1 commit into from
Aug 8, 2023

Conversation

he11owthere
Copy link
Contributor

@he11owthere he11owthere commented Aug 8, 2023

closes #20774

image

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 8, 2023
Copy link
Contributor

@iamjameskeane iamjameskeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iamjameskeane
Copy link
Contributor

iamjameskeane commented Aug 8, 2023

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

@iamjameskeane iamjameskeane merged commit b4102f4 into ivy-llc:master Aug 8, 2023
249 of 267 checks passed
Sarvesh-Kesharwani pushed a commit to Sarvesh-Kesharwani/ivy_Sark42 that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tensor.test_torch_trunc
3 participants