Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max_pool3d to pytorch frontend #22038

Merged
merged 10 commits into from
Sep 14, 2023
Merged

Conversation

progs2002
Copy link
Contributor

close #22024

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 16, 2023
@paulaehab
Copy link
Contributor

HI @progs2002 Thanks for contributing could please add the tests for your frontend function please follow this guide: (https://unify.ai/docs/ivy/overview/deep_dive/ivy_frontends_tests.html )

@progs2002
Copy link
Contributor Author

Yes, I am working on it.

@progs2002
Copy link
Contributor Author

@paulaehab I have implemented a test for the function. Could you please take a look at this?

@paulaehab
Copy link
Contributor

Hi @progs2002 Great work 👍 but you have to run the tests and make it successful run I tested the function, and it fails in all backends
image
as you can see, the error is because the output and input size

@progs2002
Copy link
Contributor Author

Had some issues with the merge, I'll make the necessary changes.

@progs2002
Copy link
Contributor Author

@paulaehab The tests are passing now except for the paddle backend (as max pooling with dilation is not currently supported). Can you please take a look?

@paulaehab
Copy link
Contributor

@paulaehab The tests are passing now except for the paddle backend (as max pooling with dilation is not currently supported). Can you please take a look?

yeah nice work I just need you to keep the file changes only of this function please un commit the changes in (devcontainer and torch comparison_ops.py) and I will merge it.

@progs2002
Copy link
Contributor Author

@paulaehab Yep, it's done.

@paulaehab
Copy link
Contributor

Hi @progs2002 lgt thanks for contributing 😄

@paulaehab paulaehab merged commit 09473c3 into ivy-llc:main Sep 14, 2023
131 of 133 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_pool3d
3 participants