-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add max_pool3d to pytorch frontend #22038
Conversation
Thanks for contributing to Ivy! 😊👏 |
HI @progs2002 Thanks for contributing could please add the tests for your frontend function please follow this guide: (https://unify.ai/docs/ivy/overview/deep_dive/ivy_frontends_tests.html ) |
Yes, I am working on it. |
@paulaehab I have implemented a test for the function. Could you please take a look at this? |
Hi @progs2002 Great work 👍 but you have to run the tests and make it successful run I tested the function, and it fails in all backends |
Had some issues with the merge, I'll make the necessary changes. |
@paulaehab The tests are passing now except for the paddle backend (as max pooling with dilation is not currently supported). Can you please take a look? |
yeah nice work I just need you to keep the file changes only of this function please un commit the changes in (devcontainer and torch comparison_ops.py) and I will merge it. |
5735981
to
9080772
Compare
@paulaehab Yep, it's done. |
3ceddf1
to
38fa241
Compare
Hi @progs2002 lgt thanks for contributing 😄 |
close #22024