Close #21810

[DevBhuyan]

Closes #21810
#21810

From ToDo list: #14945
#14945

Update:

1. Added transformer layer in ~/ivy/ivy/stateful/layers.py
2. Added test test_transformer_layer in ~/ivy/ivy_tests/test_ivy/test_stateful/test_layers.py
3. Added custom composite strategy to generate data (ref. transformer_data())

This is my first PR. I tried to make it as appropriate as possible. Please let me know if there are any modifications that you'd suggest. Thank you!😊

[github-actions]

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

[yopknopixx]

Hey, @DevBhuyan could you please link the open issue in the PR description?

[DevBhuyan]

Sure @yopknopix. I have updated the initial comment accordingly. I've included the open issue #21810 as well as the corresponding ToDo list. Thank you!

[yopknopixx]

Can you pull the latest changes from master? There seems to be some issue with the testing pipeline, no tests are being run. Thanks!

[DevBhuyan]

Sure, I've synced my version of the fork again. I can see that one of the checks run_tests (1) (pull_request) has failed. This has been constantly failing for all of the previous commits. I guess it's safe to ignore that one, as mentioned here:

Thanks for contributing to Ivy! 😊👏 Here are some of the important points from our Contributing Guidelines 📝: 1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀........

I hope it helped. Please let me know if there is still an issue. Thank you 😇

[yopknopixx]

@DevBhuyan You should not use NumPy for this. Please use ivy functions.

[DevBhuyan]

Oops! My bad, I'll change it. I assumed the other way😅

[yopknopixx]

@DevBhuyan it seems for some reason the tests are not running at all. As for run_tests (1) (pull_request) you're correct, but that's only when tests are running and failing.

[DevBhuyan]

Oh I see, please let me know if there's something I need to do to help resolve the testing issue. Meanwhile I'll fix the code and commit again. Thank you 😇

[yopknopixx]

Can you try creating a new branch on your fork from unifyai:main, implementing these changes, and creating a new PR?

[DevBhuyan]

Sure! I'll do that then.

[DevBhuyan]

Dear @yopknopixx, I have created the new branch DevBhuyan:secondary, committed the changes, and started a fresh pull request here. I have copy-pasted the description as it is:

Closes #21810 #21810

From ToDo list: #14945 #14945
....

Is there any action to be taken with this PR (current thread)?

[yopknopixx]

Hey @DevBhuyan, we can close this PR. The tests seem to be working fine on the new one.

[DevBhuyan]

Alright, thanks 😇. But I guess the new PR is being handled by someone else, is it?