Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paddle.tensor.tensor.Tensor.squeeze function #22455

Conversation

AliTarekk
Copy link
Contributor

@AliTarekk AliTarekk commented Aug 24, 2023

Add the paddle.Tensor instance method squeeze for the paddle frontend

Close #22451

Add the paddle.Tensor instance method squeeze for the paddle frontend
@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 24, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@AliTarekk
Copy link
Contributor Author

close #22451

Add test for paddle.Tensor instance method squeeze for paddle frontend
@AliTarekk
Copy link
Contributor Author

@Sam-Armstrong kindly review my PR

Copy link
Contributor

@Sam-Armstrong Sam-Armstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AliTarekk please could you make the frontend implementation and test part of the same PR? You can just update this PR to add the test. Thanks!

…nto feature/add-frontend-function-paddle-tensor-squeeze
@AliTarekk
Copy link
Contributor Author

@AliTarekk please could you make the frontend implementation and test part of the same PR? You can just update this PR to add the test. Thanks!

@Sam-Armstrong I merged the branch with the test part to this branch. Let me know if it needs further modification. Thank you!

Copy link
Contributor

@Sam-Armstrong Sam-Armstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of minor changes, but otherwise looks good to me. Thanks for the contribution @AliTarekk!

@Sam-Armstrong
Copy link
Contributor

Sam-Armstrong commented Aug 24, 2023

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

@Sam-Armstrong
Copy link
Contributor

@AliTarekk Oh wait sorry, the issue you've linked to this PR was opened and is being worked on by someone else. For that reason I'll have to close this PR. Feel free to open your own issue from one of our todo list items!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

squeeze
4 participants