-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paddle.tensor.tensor.Tensor.squeeze function #22455
Add paddle.tensor.tensor.Tensor.squeeze function #22455
Conversation
Add the paddle.Tensor instance method squeeze for the paddle frontend
Thanks for contributing to Ivy! 😊👏 |
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
close #22451 |
Add test for paddle.Tensor instance method squeeze for paddle frontend
@Sam-Armstrong kindly review my PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AliTarekk please could you make the frontend implementation and test part of the same PR? You can just update this PR to add the test. Thanks!
…nto feature/add-frontend-function-paddle-tensor-squeeze
@Sam-Armstrong I merged the branch with the test part to this branch. Let me know if it needs further modification. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a couple of minor changes, but otherwise looks good to me. Thanks for the contribution @AliTarekk!
ivy-gardener |
@AliTarekk Oh wait sorry, the issue you've linked to this PR was opened and is being worked on by someone else. For that reason I'll have to close this PR. Feel free to open your own issue from one of our todo list items! |
Add the paddle.Tensor instance method squeeze for the paddle frontend
Close #22451