Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add frontend function paddle tensor nanmean #22514

Conversation

AliTarekk
Copy link
Contributor

Add paddle.Tensor.nanmean fronend function
Add test for paddle.Tensor.nanmean function

Close #22510

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 25, 2023
@AliTarekk
Copy link
Contributor Author

@KevinUli kindly review my PR

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@KevinUli
Copy link
Contributor

Hi @AliTarekk ,
Thanks for the PR, I have left a request considering the changes you have added. I also notice the tests for nanmean seems to be failing. Please feel free to request a re-review after the changes.

@AliTarekk AliTarekk force-pushed the feature/add-frontend-function-paddle-tensor-nanmean branch from 11f3db7 to faa03fc Compare August 27, 2023 16:41
@AliTarekk
Copy link
Contributor Author

Hi @AliTarekk , Thanks for the PR, I have left a request considering the changes you have added. I also notice the tests for nanmean seems to be failing. Please feel free to request a re-review after the changes.

Hello, @KevinUli ,
Thanks for your review! Kindly re-review my PR after resolving all the issues. Thanks again!

@KevinUli
Copy link
Contributor

The tests seems to still be failing as shown in the run_tests (1) and display_test_results units of the CI checks. Please resolve them and the branch conflicts. Thanks and feel free to re-request a review

@Sarvesh-Kesharwani
Copy link
Contributor

Closing the PR for the time being, since there has been no activity for more than 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nanmean
4 participants