Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add frontend function pytorch eigh #22637

Merged

Conversation

AliTarekk
Copy link
Contributor

Add linear algebra eigh function to PyTorch frontend

Close #22636

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 27, 2023
@AliTarekk
Copy link
Contributor Author

@nathzi1505 Kindly review my PR. Thanks!

@p3jitnath
Copy link
Contributor

Hi @AliTarekk can you check the lint issues for me?
Everything else looks good.

@AliTarekk
Copy link
Contributor Author

Hi @AliTarekk can you check the lint issues for me? Everything else looks good.

Hello @nathzi1505 I fixed the linting issue. I am not sure what I should do about the persisting linting error. Would be amazing if you take a look at it and get back to me. Thanks!

@p3jitnath p3jitnath merged commit a6307a8 into ivy-llc:main Sep 9, 2023
131 of 133 checks passed
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Co-authored-by: nathzi1505 <41519676+nathzi1505@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eigh
3 participants