Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cov #22811

Merged
merged 18 commits into from
Jan 31, 2024
Merged

Cov #22811

merged 18 commits into from
Jan 31, 2024

Conversation

samthakur587
Copy link
Contributor

@samthakur587 samthakur587 commented Aug 30, 2023

added the cov method to paddle frontend Tensor.

In this PR I have added the cov method to paddle frontend. which is use to calculate the covariance matrix.

Close #22490

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@samthakur587
Copy link
Contributor Author

hii , i have try my best to implement this function by reding all the docs and source code from paddle and other framework. but i stuck in a error and now getting any way to come out from this can you please help me to solve this error.

image

even i have implemented this cov method to paddle linalg frontend. there my all the cases are passing. i don't why not here they are passing.

thank you

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 30, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@github-actions
Copy link
Contributor

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@Sarvesh-Kesharwani
Copy link
Contributor

Hello @samthakur587, please resolve the merge conflicts and let me know, I'll review your PR.
Thanks

@Sarvesh-Kesharwani
Copy link
Contributor

Hi @samthakur587,
please work on the changes suggested, and also remove all the changes unrelated to the target function implementation.

@samthakur587
Copy link
Contributor Author

Hii! @Sarvesh-Kesharwani Thinks for Review i made the changes. actually there is small mistake in composite decoretor i fixed this and now it's passing all the test cases.

image

please let me know is there any other changes required. otherwise it's ready to merge 🚀

Thanks
samthakur

@samthakur587 samthakur587 self-assigned this Jan 31, 2024
@samthakur587 samthakur587 merged commit 8917d8c into ivy-llc:main Jan 31, 2024
123 of 141 checks passed
@samthakur587 samthakur587 deleted the cov branch February 3, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cov
5 participants