-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added pad
to paddle frontend
#22859
Conversation
Thanks for contributing to Ivy! 😊👏 |
Hey @abdulasiraj A couple of comments on the PR;
Review this and let me know. Thanks! |
pad
to paddle frontend pad
to paddle frontend
Hi @AbdullahSabry, |
Unfortunately when I run tests I get the error
in all backends. It might not be updated currently Update: Tested out on the PR and yes it also brings the same error. Reverting changes |
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. you're right there's problem with symmetric mode in functional API.
@AbdullahSabry Hey! I'm working on the other pad function for the NN Common paddle frontend. I noticed that you initially encountered a failure in the Thanks in advance. |
Close #22759