Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added pad to paddle frontend #22859

Merged
merged 44 commits into from
Sep 26, 2023
Merged

Conversation

AbdullahSabry
Copy link
Contributor

@AbdullahSabry AbdullahSabry commented Aug 31, 2023

Close #22759

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 31, 2023
@AbdullahSabry
Copy link
Contributor Author

Hey @abdulasiraj

A couple of comments on the PR;

  1. The mode symmetric was not implemented yet so it needed to be excluded from testing.
  2. In the original paddle function the input fill could receive a size 3 tuple with RGB. However this isn't supported in ivy.fill. Let me know if there's anything to be done to resolve this

Review this and let me know. Thanks!

@AbdullahSabry AbdullahSabry changed the title Added pad to paddle frontend feat: Added pad to paddle frontend Sep 18, 2023
@abdulasiraj
Copy link
Contributor

abdulasiraj commented Sep 19, 2023

@AbdullahSabry
Copy link
Contributor Author

AbdullahSabry commented Sep 19, 2023

@abdulasiraj

Unfortunately when I run tests I get the error

        if padding_mode == 'edge':
            padding_mode = 'replicate'
        elif padding_mode == 'symmetric':
>           raise ValueError('Do not support symmetric mode')
E           ValueError: Do not support symmetric mode

in all backends. It might not be updated currently

Update: Tested out on the PR and yes it also brings the same error. Reverting changes

@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

Copy link
Contributor

@abdulasiraj abdulasiraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. you're right there's problem with symmetric mode in functional API.

@abdulasiraj abdulasiraj merged commit 4ed970c into ivy-llc:main Sep 26, 2023
117 of 135 checks passed
@AbdullahSabry AbdullahSabry deleted the pad_paddle branch September 26, 2023 15:48
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
@shivakumarmahesh
Copy link

shivakumarmahesh commented Oct 11, 2023

@AbdullahSabry Hey! I'm working on the other pad function for the NN Common paddle frontend.

I noticed that you initially encountered a failure in the array-api-intelligent-tests-pr / run_tests (pull_request) test, which I'm also experiencing. It appears that you've resolved the issue; could you please share the solution with me?

Thanks in advance.

druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pad
4 participants