Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added max unpool 2d to paddle frontend api #22900

Closed
wants to merge 4 commits into from

Conversation

wassim249
Copy link

PR Description

Add max unpool 2D to paddle frontend API

Related Issue

Close #22898

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 1, 2023
@vaithak
Copy link
Contributor

vaithak commented Sep 1, 2023

Hi @wassim249, max_unpool2d doesn't exist in ivy's functional layer or any of the backends, so this cannot be tested. Maybe you can try pick up the task of adding this in backends first.

@wassim249
Copy link
Author

Alright,thank you @vaithak

@wassim249
Copy link
Author

hello @vaithak, I've opened an issue for the unpool2d in the paddle backend.

@ivy-seed ivy-seed assigned YushaArif99 and unassigned vaithak Sep 18, 2023
[ 0., 0., 0., 0.],
[ 0., 10., 0., 11.]]]])
"""
return ivy.current_backend(x).max_unpool2d(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there even a function called max_unpool2d in ivy 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you adding a test for test_layers.py? this has nothing to do with the PR so can you kindly revert this change?🙂

Copy link
Contributor

@YushaArif99 YushaArif99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wassim249

Apologies for the delay in review. Have been quite swamped with work recently and so haven't really had the time to review any PRs 😅

With regards to the PR itself, could you kindly address the above-mentioned points? I dont think there is a ivy.max_unpool2d function in ivy. If that's the case, this function will need to be added to the functional API of Ivy. I'd suggest closing this PR and working on a different one in the meantime as implementing functions for the Functional API is normally reserved for team members and is not open to contributors 🙂

@ivy-leaves ivy-leaves added Ivy Functional API Ivy API Experimental Run CI for testing API experimental/New feature or request labels Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_unpool2d
6 participants