-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added max unpool 2d to paddle frontend api #22900
Conversation
Thanks for contributing to Ivy! 😊👏 |
Hi @wassim249, |
Alright,thank you @vaithak |
hello @vaithak, I've opened an issue for the unpool2d in the paddle backend. |
[ 0., 0., 0., 0.], | ||
[ 0., 10., 0., 11.]]]]) | ||
""" | ||
return ivy.current_backend(x).max_unpool2d( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there even a function called max_unpool2d
in ivy
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you adding a test for test_layers.py
? this has nothing to do with the PR so can you kindly revert this change?🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wassim249
Apologies for the delay in review. Have been quite swamped with work recently and so haven't really had the time to review any PRs 😅
With regards to the PR itself, could you kindly address the above-mentioned points? I dont think there is a ivy.max_unpool2d
function in ivy
. If that's the case, this function will need to be added to the functional API of Ivy. I'd suggest closing this PR and working on a different one in the meantime as implementing functions for the Functional API is normally reserved for team members and is not open to contributors 🙂
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
PR Description
Add max unpool 2D to paddle frontend API
Related Issue
Close #22898
Checklist