Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the tanh_ to paddle tensor frontend #23247

Merged
merged 6 commits into from
Sep 27, 2023

Conversation

samthakur587
Copy link
Contributor

@samthakur587 samthakur587 commented Sep 7, 2023

added the tanh_ to paddle tensor frontend

in this PR i have added the tanh_ to paddle frontend tensor by calling the tanh it self from the same tensor class. it passing all the the backend tests.

image

Close #22298

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 7, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

on_device,
backend_fw,
):
input_dtype, x = dtype_and_x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a linting issue here. Can you please fix this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also need to see the latest test results. Can you merge main branch in your branch and run the tests again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved the lint error and tested with latest main branch pull. it is passing all the tests 😄

image

mergeeee.. 😄 🚀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vedpatwardhan this is also one of those PRs where CI fails but tests pass locally 🤔 . What could be the issue?

Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest running the tests with a larger number of examples just to confirm that it passes even then. Thanks @HaiderSultanArc @samthakur587 😄
(Given that the tests aren't running in the CI due to a docker issue, we can get the PR merged if you think all the changes are sensible @HaiderSultanArc)

@samthakur587
Copy link
Contributor Author

I'd suggest running the tests with a larger number of examples just to confirm that it passes even then. Thanks @HaiderSultanArc @samthakur587 😄 (Given that the tests aren't running in the CI due to a docker issue, we can get the PR merged if you think all the changes are sensible @HaiderSultanArc)

Hi @vedpatwardhan @HaiderSultanArc i always used to test every PR on large number of example in between 100 to 150. i already have tested this function on 150 max examples it passing all the test. i think it should be enough to test this function.

@samthakur587
Copy link
Contributor Author

this is result with 200 examples -

image

@samthakur587
Copy link
Contributor Author

Hi @vedpatwardhan and @HaiderSultanArc the error is occuring bcz the with_supported_device_and_dtypes is not define in ivy/backend/paddle/statistic.py file now it's solved.

@HaiderSultanArc
Copy link
Contributor

But you said tests were passing locally 🤔 . How did they pass locally if that's the case?

@samthakur587
Copy link
Contributor Author

But you said tests were passing locally 🤔 . How did they pass locally if that's the case?

yesterday i have pull the latest changes it still passing. but someone made changes today i think and when i pulled the todays changes then this error is comming.

@samthakur587
Copy link
Contributor Author

@vedpatwardhan @HaiderSultanArc it's still falling 😄 in dill is not finding i have install the dill in locally but i thing the problem in docker testing CI. here i think the dill has not installed.

@HaiderSultanArc HaiderSultanArc merged commit b61b780 into ivy-llc:main Sep 27, 2023
194 of 269 checks passed
@samthakur587 samthakur587 deleted the tanh_ branch September 27, 2023 16:02
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tanh_
5 participants