-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the tanh_ to paddle tensor frontend #23247
Conversation
Thanks for contributing to Ivy! 😊👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
on_device, | ||
backend_fw, | ||
): | ||
input_dtype, x = dtype_and_x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a linting issue here. Can you please fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also need to see the latest test results. Can you merge main branch in your branch and run the tests again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vedpatwardhan this is also one of those PRs where CI fails but tests pass locally 🤔 . What could be the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest running the tests with a larger number of examples just to confirm that it passes even then. Thanks @HaiderSultanArc @samthakur587 😄
(Given that the tests aren't running in the CI due to a docker issue, we can get the PR merged if you think all the changes are sensible @HaiderSultanArc)
Hi @vedpatwardhan @HaiderSultanArc i always used to test every PR on large number of example in between 100 to 150. i already have tested this function on 150 max examples it passing all the test. i think it should be enough to test this function. |
…ed_device_and_dtypes was not define
Hi @vedpatwardhan and @HaiderSultanArc the error is occuring bcz the with_supported_device_and_dtypes is not define in ivy/backend/paddle/statistic.py file now it's solved. |
But you said tests were passing locally 🤔 . How did they pass locally if that's the case? |
yesterday i have pull the latest changes it still passing. but someone made changes today i think and when i pulled the todays changes then this error is comming. |
@vedpatwardhan @HaiderSultanArc it's still falling 😄 in |
added the tanh_ to paddle tensor frontend
in this PR i have added the tanh_ to paddle frontend tensor by calling the tanh it self from the same tensor class. it passing all the the backend tests.
Close #22298
Checklist